Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource]: DataZone Form Type #38746

Merged
merged 10 commits into from
Aug 15, 2024
Merged

[New Resource]: DataZone Form Type #38746

merged 10 commits into from
Aug 15, 2024

Conversation

ThomasZalewski
Copy link
Contributor

Added support for the datazone form type resource

Description

This resource will allow practitioners to create DataZone Form Types for DataZone via Terraform.

Relations

Relates #37423

References

https://docs.aws.amazon.com/datazone/latest/APIReference/API_CreateFormType.html#datazone-CreateFormType-request-model

Output from Acceptance Testing

make testacc TESTS=TestAccDataZoneFormType PKG=datazone
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/datazone/... -v -count 1 -parallel 20 -run='TestAccDataZoneFormType'  -timeout 360m
=== RUN   TestAccDataZoneFormType_basic
=== PAUSE TestAccDataZoneFormType_basic
=== RUN   TestAccDataZoneFormType_disappears
=== PAUSE TestAccDataZoneFormType_disappears
=== CONT  TestAccDataZoneFormType_basic
=== CONT  TestAccDataZoneFormType_disappears
--- PASS: TestAccDataZoneFormType_disappears (29.94s)
--- PASS: TestAccDataZoneFormType_basic (30.28s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/datazone   35.150s

@ThomasZalewski ThomasZalewski requested a review from a team as a code owner August 7, 2024 18:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/datazone Issues and PRs that pertain to the datazone service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@johnsonaj johnsonaj disabled auto-merge August 14, 2024 19:37
@johnsonaj johnsonaj self-assigned this Aug 14, 2024
johnsonaj
johnsonaj approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS="-run=TestAccDataZoneFormType_" PKG=datazone

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.6 test ./internal/service/datazone/... -v -count 1 -parallel 20  -run=TestAccDataZoneFormType_ -timeout 360m
--- PASS: TestAccDataZoneFormType_disappears (29.67s)
--- PASS: TestAccDataZoneFormType_basic (30.91s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/datazone	36.975s

@johnsonaj
Copy link
Contributor

@ThomasZalewski thank you for the contribution! 🎉

@johnsonaj johnsonaj merged commit 80dff95 into main Aug 15, 2024
42 checks passed
@johnsonaj johnsonaj deleted the f/datazone/form-type branch August 15, 2024 20:41
@github-actions github-actions bot added this to the v5.63.0 milestone Aug 15, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 15, 2024
Update CHANGELOG.md for #38746
dd68fed
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 15, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.63.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees

@johnsonaj johnsonaj

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/datazone Issues and PRs that pertain to the datazone service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.63.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ThomasZalewski @johnsonaj